New Config API support #1499
Merged
New Config API support #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(config): add root&application config api * feat(config): add protocol config api * feat(config): remove structure embedding * feat(config): add registry config api builder * feat(config): add service discovery config api builder * feat(config): add prefix Set * feat(config): add consumer&provider&metric&metadata&remote_route&logger config api Co-authored-by: dongjianhui03 <[email protected]>
LaurenceLiZhixin
requested review from
zhaoyunxing92 and
AlexStocks
and removed request for
zhaoyunxing92
|
This pr's ci may pass after this pr merge: The config API samples is updating |
Codecov Report
@@ Coverage Diff @@
## 3.0 #1499 +/- ##
==========================================
- Coverage 42.71% 42.10% -0.62%
==========================================
Files 261 261
Lines 14957 15179 +222
==========================================
+ Hits 6389 6391 +2
- Misses 7819 8044 +225
+ Partials 749 744 -5
Continue to review full report at Codecov.
|
AlexStocks
approved these changes
Oct 2, 2021
config/provider_config.go
Outdated
| // Registry registry ids | ||
| Registry []string `yaml:"registry" json:"registry" property:"registry"` | ||
| // Registries registry ids TODO Registries? | ||
| Registries []string `yaml:"registries" json:"registries" property:"registries"` |
There was a problem hiding this comment.
为什么要修改这个？这个只是注册中心的ids
There was a problem hiding this comment.
IDs 也要用复数吧？
There was a problem hiding this comment.
IDs 也要用复数吧？
AlexStocks
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.